docs(service-worker): various small fixes/improvements in SW docs #37555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
comp: docs
area: service-worker
|
You can preview 01ca0d5 at https://pr37555-01ca0d5.ngbuilds.io/. |
gkalpak
force-pushed
the
docs-sw-registration
branch
from
01ca0d5
to
9c78503
Compare
|
You can preview 9c78503 at https://pr37555-9c78503.ngbuilds.io/. |
kapunahelewong
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Just a few style suggestions. Thank you, @gkalpak!
Reviewed-for: global-docs-approvers
gkalpak
added
action: cleanup
…registrationStrategy` The default value was changed from `registerWhenStable` to `registerWhenStable:30000` in 29e8a64, but the decumentation was not updated to reflect that. This commit updates the documentation to mention the correct default value.
…n guide This commit includes various fixes/improvements for the "Service worker communication" guide. This partially addresses angular#37527.
gkalpak
force-pushed
the
docs-sw-registration
branch
from
9c78503
to
96c8ec7
Compare
gkalpak
added
action: merge
|
You can preview 96c8ec7 at https://pr37555-96c8ec7.ngbuilds.io/. |
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
…registrationStrategy` (angular#37555) The default value was changed from `registerWhenStable` to `registerWhenStable:30000` in 29e8a64, but the decumentation was not updated to reflect that. This commit updates the documentation to mention the correct default value. PR Close angular#37555
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
…n guide (angular#37555) This commit includes various fixes/improvements for the "Service worker communication" guide. This partially addresses angular#37527. PR Close angular#37555
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…registrationStrategy` (angular#37555) The default value was changed from `registerWhenStable` to `registerWhenStable:30000` in 29e8a64, but the decumentation was not updated to reflect that. This commit updates the documentation to mention the correct default value. PR Close angular#37555
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…n guide (angular#37555) This commit includes various fixes/improvements for the "Service worker communication" guide. This partially addresses angular#37527. PR Close angular#37555
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: update default value of
SwRegistrationOptions#registrationStrategyThe default value was changed from
registerWhenStabletoregisterWhenStable:30000in 29e8a64, but the decumentation was not updated to reflect that.This commit updates the documentation to mention the correct default value.
Commit 2: docs(service-worker): minor fixes/improvements in the SW Communication guide
This commit includes various fixes/improvements for the "Service worker communication" guide.
This PR partially addresses #37527.